Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger Characters missing in formatAfterKeyStroke #1906

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Trigger Characters missing in formatAfterKeyStroke #1906

wants to merge 2 commits into from

Conversation

akshita31
Copy link
Contributor

@akshita31 akshita31 commented Dec 5, 2017 •
edited
Loading

Issue : #1591

To ensure proper bracket styling, entering '{' should trigger a format request. Also '\n' is one of the expected characters for triggering the format request. It was present in omnisharp-roslyn but not present as trigger character on the vscode side.

Please review : @DustinCampbell @TheRealPiotrP @rchande

@akshita31 akshita31 mentioned this pull request Dec 5, 2017
Open
@akshita31
Copy link
Contributor Author

omnisharp-roslyn side : OmniSharp/omnisharp-roslyn#1042

@ghost ghost removed the cla-already-signed label Dec 7, 2017
@DustinCampbell
Copy link
Member

@TheRealPiotrP: Should there be a label for cross-cutting changes like these that depend on a new OmniSharp build?

@gregg-miskelly
Copy link
Contributor

Should this be merged now?

@akshita31
Copy link
Contributor Author

This is blocked on : OmniSharp/omnisharp-roslyn#1042 and microsoft/vscode#40235

@TheRealPiotrP
Copy link

@akshita31 still blocked?

@colombod colombod mentioned this pull request Mar 6, 2018
Closed
@DustinCampbell
Copy link
Member

Is there anything blocking this?

@akshita31
Copy link
Contributor Author

@DustinCampbell I haven't looked into this one for some time. Will take it up now.

@akshita31
Copy link
Contributor Author

I am not sure what is the correct approach to deal with this.

@mletterle mletterle mentioned this pull request Nov 9, 2019
Closed
@Ashen-Vaults
Copy link

Any updates on when this will be merged?

@Kira-Pilot
Copy link

Any news on this?

@gabrieldechichi
Copy link

Any Updates on this? It shows it's been waiting to be merged for a while now.

@JoeRobich JoeRobich mentioned this pull request Jul 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealPiotrP TheRealPiotrP TheRealPiotrP approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Blocked on OmniSharp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@akshita31 @DustinCampbell @gregg-miskelly @TheRealPiotrP @Ashen-Vaults @Kira-Pilot @gabrieldechichi @dnfclas